Hi, Bernard.

PSB.

> -----Original Message-----
> From: Iremonger, Bernard <bernard.iremon...@intel.com>
> Sent: Thursday, June 20, 2019 18:15
> To: Slava Ovsiienko <viachesl...@mellanox.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yi...@intel.com>
> Subject: RE: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst
> routines
> 
> Hi  Slava,
> 
> 
> > -----Original Message-----
> > From: Slava Ovsiienko [mailto:viachesl...@mellanox.com]
> > Sent: Monday, June 10, 2019 5:40 AM
> > To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org
> > Cc: Yigit, Ferruh <ferruh.yi...@intel.com>
> > Subject: RE: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx
> > burst routines
> >
> <snip>
> 
> > > >  static void
> > > > diff --git a/config/common_base b/config/common_base index
> > > > 6b96e0e..6e84af4 100644
> > > > --- a/config/common_base
> > > > +++ b/config/common_base
> > > > @@ -998,6 +998,8 @@ CONFIG_RTE_PROC_INFO=n  #
> > > CONFIG_RTE_TEST_PMD=y
> > > > CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES=n
> > > > +CONFIG_RTE_TEST_PMD_RECORD_CORE_RX_CYCLES=n
> > > > +CONFIG_RTE_TEST_PMD_RECORD_CORE_TX_CYCLES=n
> > > >  CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS=n
> > >
> > > Should the RECORD macros be documented in the run_app.rst file ?
> 
> You missed the above comment in your reply.

Yes, I missed the comment, sorry for this.
Thank you for gentle reminding, I will add documentation part to the patch.

> There seems to be no documentation on the RECORD macros at present,
> there probably should be some.
> 
> Regards,
> 
> Bernard.
> 
With best regards,
Slava

Reply via email to