On 08/12/2015 11:47, Panu Matilainen wrote: > Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but > for libraries. Clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion > while at it. > > Requiring applications to know about library internal details like > dependencies to external helper libraries is a limitation of > static linkage, shared libraries should always know their own > dependencies for sane operation. > > Linking with the combined library (whether shared or not) still > requires knowing the internal dependencies, and intra-dpdk > dependencies are also not currently recorded. > > Signed-off-by: Panu Matilainen <pmatilai at redhat.com> > --- > > v2: > - clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion while at it > > Hi Panu,
Patch itself looks good but there is a small side effect on BSD that results in app/test not linking because of missing -lm. Linuxapp links with -lm by default (EXECENV_LDLIBS), but BSD does not. Should we just add -lm to EXECENV_LDLIBS for BSD too instead of adding it on each app/example that uses librte_sched ? Sergio
