On 12/08/2015 01:19 PM, Panu Matilainen wrote:
> On 12/08/2015 12:11 PM, Thomas Monjalon wrote:
>> Hi Panu,
>>
>> 2015-12-08 10:30, Panu Matilainen:
>>> --- a/lib/librte_vhost/Makefile
>>> +++ b/lib/librte_vhost/Makefile
>>> @@ -44,10 +44,12 @@ CFLAGS += -I vhost_user
>>> else
>>> CFLAGS += -I vhost_cuse -lfuse
>>> LDFLAGS += -lfuse
>>> +LDLIBS += -lfuse
>>> endif
>>>
>>> ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
>>> LDFLAGS += -lnuma
>>> +LDLIBS += -lnuma
>>> endif
>>
>> It looks weird to have to declare the dependencies both in
>> LDFLAGS and LDLIBS. What is the reason?
>> Can we improve it?
>
> I'd say its just an artifact of the dpdk build system evolution and
> surely we can improve it, but I'd leave it post 2.2 to avoid breaking
> anything now.
Actually, scratch that. That librte_vhost has used LDFLAGS instead of
LDLIBS is likely just a mistake that happens to work, but there should
be no reason for it.
I'll send a v2 with that changed, and while at it, remove the bogus
-lfuse from vhost_cuse CFLAGS too.
- Panu -
