On 6/6/2019 12:06 PM, Ziyang Xuan wrote:
> Add various headers that define mgmt commands, cmdq commands,
> rx data structures, tx data structures and basic defines for
> use in the code.
> 
> Signed-off-by: Ziyang Xuan <xuanziya...@huawei.com>

<...>

> +#define PMD_DRV_LOG(level, fmt, args...) \
> +     rte_log(RTE_LOG_ ## level, hinic_logtype, \
> +             HINIC_DRIVER_NAME": " fmt "\n", ##args)
> +
> +#define HINIC_ASSERT_EN
> +
> +#ifdef HINIC_ASSERT_EN
> +#define HINIC_ASSERT(exp)    \
> +     do {                    \
> +             if (!(exp)) {   \
> +                     rte_panic("line%d\tassert \"" #exp "\" failed\n", \
> +                               __LINE__);    \
> +             }               \
> +     } while (0)
> +#else
> +#define HINIC_ASSERT(exp)    do {} while (0)
> +#endif

So you are enabling asserting by default? Which can cause "rte_panic()" ?

Please make sure asserting is disabled by default, and please tie this to the
"CONFIG_RTE_ENABLE_ASSERT" config option. So it that option is disabled hinic
also should disable the assertions.
  • ... Ziyang Xuan
    • ... Ferruh Yigit
  • ... Ziyang Xuan
  • ... Ziyang Xuan
    • ... Ferruh Yigit
  • ... Ziyang Xuan
  • ... Ziyang Xuan
  • ... Ziyang Xuan
  • ... Ziyang Xuan
  • ... Ziyang Xuan
    • ... Ferruh Yigit
  • ... Ziyang Xuan
    • ... Ferruh Yigit
      • ... Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)

Reply via email to