On Mon, Dec 07, 2015 at 03:03:24AM +0100, Thomas Monjalon wrote:
> 2015-12-07 10:00, Yuanhan Liu:
> > On Mon, Dec 07, 2015 at 12:07:28AM +0100, Thomas Monjalon wrote:
> > > 2015-12-02 15:53, Panu Matilainen:
> > > > This (and other changes in patch 2 breaks the librte_vhost ABI again,
> > > > so
> > > > you'd need to at least add a deprecation note to 2.2 to be able to do
> > > > it
> > > > in 2.3 at all according to the ABI policy.
> > > >
> > > > Perhaps a better option would be adding some padding to the structs now
> > > > for 2.2 since the vhost ABI is broken there anyway. That would at least
> > > > give a chance to keep it compatible from 2.2 to 2.3.
> > >
> > > Please could you point where the vhost ABI is broken in 2.2?
> >
> > Thomas, here are the changes to rte_virtio_net.h:
> >
> >
> > $ git diff
> > 381316f6a225139d22d39b5ab8d50c40607924ca..19d4d7ef2a216b5418d8edb5b004d1a58bba3cc1
> > \
> > -- lib/librte_vhost/rte_virtio_net.h >
> [...]
>
> The problem is that the changes are not noticed in the release notes
> and the LIBABIVER is still 1.
Yeah, my bad. Firstly, I was not aware of it's an ABI change. Secondly,
I was landed to this team in the middle of v2.2 release, so that I have
limited experience of how those works in DPDK community.
Anyway, it's my fault. I should have realized that in the first time.
Should I send a patch to update LIBABIVER to 2 and update release note
now?
--yliu
