> -----Original Message----- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, May 30, 2019 10:57 AM > To: Walker, Benjamin <benjamin.wal...@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 02/12] eal/pci: Inline several functions into > rte_pci_get_iommu_class > > On Thu, 30 May 2019 10:48:09 -0700 > Ben Walker <benjamin.wal...@intel.com> wrote: > > > This is in preparation for future simplifications. The functions are > > simply inlined for now. > > > > Signed-off-by: Ben Walker <benjamin.wal...@intel.com> > > Change-Id: I129992c9b44f4575a28cc05b78297e15b6be4249 > > Please don't inline any functions that are not in the fast path. > The compiler will do it anyway.
That's not what I mean by inline. I didn't mark the functions inline - I copied their contents into the single place they are called. This patch is a set up patch for a later one that refactors the way this function works, and doing this makes the diff easier to read.
