On Thu, May 30, 2019 at 03:06:17PM +0300, Ilya Maximets wrote:
> On 30.05.2019 14:55, Bruce Richardson wrote:
> > On Wed, May 29, 2019 at 07:39:57PM +0300, Ilya Maximets wrote:
> >> Don't need to check dependencies if test apps will not be built anyway.
> >>
> >> Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
> >> ---
> >> app/test/meson.build | 38 +++++++++++++++++++-------------------
> >> 1 file changed, 19 insertions(+), 19 deletions(-)
> >>
> > Agree with the idea.
> >
> > Would this work as a shorter alternative placed at the top of the file?
> >
> > if not get_option('tests')
> > subdir_done()
> > endif
>
> This looks good to me.
> However, the resulted patch will be much larger because we'll have to
> shift most of it to the left. If it's OK, I'll prepare v2 with this change.
> What do you think?
>
Yes, there will be some left-shifting, but it should just be a single block
from lines 338-419, which is probably ok. The end result is better, I
think.
