> -----Original Message----- > From: Bruce Richardson <bruce.richard...@intel.com> > Sent: Tuesday, May 28, 2019 4:38 PM > To: dev@dpdk.org > Cc: Shreyansh Jain <shreyansh.j...@nxp.com>; Alejandro Lucero > <alejandro.luc...@netronome.com>; Anatoly Burakov > <anatoly.bura...@intel.com>; sta...@dpdk.org; Maxime Coquelin > <maxime.coque...@redhat.com>; Zhihong Wang <zhihong.w...@intel.com>; Luca > Boccassi <bl...@debian.org>; Zhang XuemingX <xuemingx.zh...@intel.com>; Bruce > Richardson <bruce.richard...@intel.com> > Subject: [PATCH v2 2/5] build: enable large file support on 32-bit > > By default on 32-bit systems, file offsets are given as 32-bit values > which prevents support for large files. While this is unlikely to be > a problem, enabling large file support globally makes "make" and > "meson" builds consistent, since meson always enables large file > support, and without this change, the size of "struct stat" fields > will be different between the two builds. > > The only location where this appears to be significant is in the > dpaax common code, where a printf needs to be updated for 32-bit > builds.
>From DPAAX perspective, I am not worried about 32bit and dependency of large >file support. So, this 'don't care' from my side. > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > Acked-by: Luca Boccassi <bl...@debian.org> > --- > drivers/common/dpaax/dpaax_iova_table.c | 4 ++-- > mk/arch/arm/rte.vars.mk | 2 +- > mk/arch/i686/rte.vars.mk | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > If this patch is merged, please ignore [1] [1] http://patches.dpdk.org/patch/53798/ Acked-by: Shreyansh Jain <shreyansh.j...@nxp.com>
