On Tue, May 21, 2019 at 04:29:31PM +0800, lin li wrote:
> Tiwei Bie <tiwei....@intel.com> 于2019年5月20日周一上午10:14写道:
> >
> > On Fri, May 17, 2019 at 05:47:07PM +0200, Maxime Coquelin wrote:
> > > On 5/5/19 11:02 AM, Li Lin wrote:
> > [...]
> > > >   /**
> > > >    * Device structure contains all configuration information relating
> > > >    * to the device.
> > > > @@ -303,6 +314,7 @@ struct virtio_net {
> > > >     uint32_t                nr_vring;
> > > >     int                     dequeue_zero_copy;
> > > >     struct vhost_virtqueue  *virtqueue[VHOST_MAX_QUEUE_PAIRS * 2];
> > > > +   struct inflight_mem_info inflight_info;
> > > >   #define IF_NAME_SZ (PATH_MAX > IFNAMSIZ ? PATH_MAX : IFNAMSIZ)
> > > >     char                    ifname[IF_NAME_SZ];
> > > >     uint64_t                log_size;
> > >
> > > Do you have some code example using these new APIs?
> > > It would help for reviewing the patch.
> >
> > +1
> I just submitted SPDK-related patches, and you will see how to use new API.

SPDK is another separate project. For the DPDK APIs introduced
in this patch, it would be great to have an example in DPDK to
demonstrate their usage, e.g. examples/vhost_scsi. Besides, the
new APIs also need to take the packed ring into consideration.

Thanks,
Tiwei

Reply via email to