Hi Stephen, Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Friday, December 4, 2015 3:30 AM > To: Stephen Hemminger <stephen at networkplumber.org> > Cc: Xie, Huawei <huawei.xie at intel.com>; Iremonger, Bernard > <bernard.iremonger at intel.com>; dev at dpdk.org > Subject: Re: [PATCH] virtio: fix link state regression > > On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote: > > Support for link state interrupt was broken on virtio by > > > > commit bda66c418c85 ("ethdev: add device fields from PCI layer") > > > > This is caused because the actual value of drv_flags is not set until > > after the resource_init has figured out whether it is using UIO or > > direct I/O instructions. > > > > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org> > > --- > > There maybe other drivers with the same problem. It would have been > > better to move the structure elements (and break ABI) rather than > > assume it safe to copy them. Better to fail compiling. > > I see no patch content. > > --yliu
I have submitted a patch for this issue. http://dpdk.org/dev/patchwork/patch/9345/ I have checked the other drivers, I found an issue with the bonding PMD. I have submitted a patch for this. http://dpdk.org/dev/patchwork/patch/9342/ The remaining drivers look fine to me. Regards, Bernard.
