Re: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf

[Ananyev, Konstantin]

> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sunil Kumar Kori
> Sent: Thursday, May 16, 2019 12:42 PM
> To: dev@dpdk.org
> Cc: sk...@marvell.com
> Subject: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP 
> checksum offload in mbuf
> 
> As per the documentation to use any IP offload features, application
> must set required offload flags into mbuf->ol_flags.
> 
> Signed-off-by: Sunil Kumar Kori <sk...@marvell.com>
> ---
>  examples/ip_fragmentation/main.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/ip_fragmentation/main.c 
> b/examples/ip_fragmentation/main.c
> index e90a61e..d821967 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -354,10 +354,13 @@ struct rte_lpm6_config lpm6_config = {
> 
>               /* src addr */
>               ether_addr_copy(&ports_eth_addr[port_out], &eth_hdr->s_addr);
> -             if (ipv6)
> +             if (ipv6) {
>                       eth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv6);
> -             else
> +                     m->ol_flags |= PKT_TX_IPV6;

Is there is any point to do that?
This sample app, as I remember doesn't request any extra HW offloads.
Same comment for patch #3.
Konstantin


> +             } else {
>                       eth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv4);
> +                     m->ol_flags |= (PKT_TX_IPV4 | PKT_TX_IP_CKSUM);
> +             }
>       }
> 
>       len += len2;
> --
> 1.8.3.1