On Thu, May 9, 2019 at 3:29 PM Jens Freimann <jfreim...@redhat.com> wrote:
> On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote: > >This .rx_queue_setup devop is called after ethdev already dereferenced > >the mempool pointer. > >No need to check and we can remove this rte_exit. > > > >Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper > place") > >Cc: sta...@dpdk.org > > > >Signed-off-by: David Marchand <david.march...@redhat.com> > > Agree, the pointer is accessed before in the caller. That said, afaics the > pointer is never checked in rte_eth_rx_queue_setup() before it's > dereferenced... > Yep, sent a patch. http://patchwork.dpdk.org/patch/53503/ Thanks for the review Jens. -- David Marchand