> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Monday, May 13, 2019 4:47 PM > To: Morten Brørup > Cc: Olivier Matz; tho...@monjalon.net; ferruh.yi...@intel.com; > arybche...@solarflare.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h > instead of in rte_eth_ctrl.h > > On Mon, 13 May 2019 15:02:57 +0200 > Morten Brørup <m...@smartsharesystems.com> wrote: > > > > > > > IMHO, adding the copyright for flags move is a bit overkill. > > > > I also added the two ECN flags and descriptions of all the flags. And > removed the misleading ALL flag. > > > > I don't know the formal or customary threshold criteria for adding a > copyright notice, so I just added it. It's our first direct contribution > where we didn't just send the corrections to another contributor, so I > thought it would be nice to have our name in here. You're the maintainer, > so I'll leave the final decision up to you. > > Most projects including DPDK do not add additional copyrights unless it > is a complete rewrite. Please don't clutter the code with this stuff.
That's a quite clear threshold definition, and my modifications clearly don't fall into this category. Med venlig hilsen / kind regards - Morten Brørup
