re-send with fixed Cc
10/05/2019 20:17, Thomas Monjalon:
> 10/05/2019 19:14, Smoczynski, MarcinX:
> > To summarize we have different visibility sets for Linux and BSD when using
> > XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome this situation we can
> > either remove problematic XOPEN macros from mk/meson rules
> > (drivers/net/failsafe,
> > drivers/net/mlx4, drivers/net/mlx5)
>
> What is the consequence of removing these macros in mlx and failsafe PMDs?
>
> > or add explicit -D__BSD_VISIBLE when
> > building for BSD. I think also that defining _GNU_SOURCE for BSD builds
> > makes no
> > sense although it does not cause any problems.
> >
> > I have checked that removing those problematic macros solves build problems
> > on
> > FreeBSD12 and does not break on Ubuntu 18.04.
