Hi Ayuj, Akhil, From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Wednesday, April 17, 2019 10:58 AM To: Ayuj Verma <ayve...@marvell.com>; Trahe, Fiona <fiona.tr...@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com> Cc: Shally Verma <shal...@marvell.com>; Sunila Sahu <ss...@marvell.com>; Kanaka Durga Kotamarthy <kkotamar...@marvell.com>; Arvind Desai <ade...@marvell.com>; dev@dpdk.org Subject: Re: [PATCH v1] fix alphabetical ordering of headers
Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.go...@nxp.com<mailto:akhil.go...@nxp.com>; Kusztal, ArkadiuszX > <arkadiuszx.kusz...@intel.com<mailto:arkadiuszx.kusz...@intel.com>>; Trahe, > Fiona > <fiona.tr...@intel.com<mailto:fiona.tr...@intel.com>> > Cc: shal...@marvell.com<mailto:shal...@marvell.com>; > ss...@marvell.com<mailto:ss...@marvell.com>; > kkotamar...@marvell.com<mailto:kkotamar...@marvell.com>; > ade...@marvell.com<mailto:ade...@marvell.com>; > dev@dpdk.org<mailto:dev@dpdk.org>; Ayuj Verma > <ayve...@marvell.com<mailto:ayve...@marvell.com>> > Subject: [PATCH v1] fix alphabetical ordering of headers > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.h, it probably shouldn't. What's the dependency and can/should it be moved to rte_crypto.h? [Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So do you suggest to move it to rte_crypto.h? [Akhil] moving the enum is not a good idea. I believe we do not need this change at all. Keeping the headers in alphabetical order may be a preferred way, But it should not be mandatory, there may be some dependencies like this. [Fiona] I agree with not moving the enum, now that I understand the dependency. Either no change or the original patch are fine with me.
