On 4/10/2018 2:19 PM, Burakov, Anatoly wrote: > On 10-Apr-18 11:55 AM, Tosatti, Giovanni wrote: >> This patch adds a " --restore" option that will unbind all devices currently >> bound to DPDK PMDs back to the kernel driver. >> >> --- >> /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07.orig/tools/dpdk-devbind.py >> +++ >> /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07/tools/dpdk-devbind.py >> @@ -91,6 +91,9 @@ >> -u, --unbind: > > Two other issues: > > 1) the header is also wrongly formatted. it should read something like: > > tools/devbind: add option to restore kernel driver binding > > 2) the patch does not apply. not only it appears to be generated not > from git-send-email but reads as a diff, but it looks like it's > generated against a very old version of DPDK. > > You might want to look at DPDK contribution guidelines: > > http://dpdk.org/doc/guides/contributing/patches.html > > Thanks for your effort so far! >
There is no response to change request for a year now. I am marking the patch as rejected, if it is still relevant please send a new version on top of latest repo. Sorry for any inconvenience caused. For reference patches: https://patches.dpdk.org/patch/37774/
