03/04/2019 19:13, Eads, Gage: > > 02/04/2019 13:14, Honnappa Nagarahalli: > > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > > > > > The rte_stack library provides an API for configuration and use of a > > > > bounded stack of pointers. Push and pop operations are MT-safe, > > > > allowing concurrent access, and the interface supports pushing and > > > > popping multiple pointers at a time. > > > > > > > > The library's interface is modeled after another DPDK data > > > > structure, rte_ring, and its lock-based implementation is derived > > > > from the stack mempool handler. An upcoming commit will migrate the > > > > stack mempool handler to rte_stack. > > > > > > > > Signed-off-by: Gage Eads <gage.e...@intel.com> > > > > Reviewed-by: Olivier Matz <olivier.m...@6wind.com> > > > > --- > > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > > > It does not compile for Arm: > > > > lib/librte_stack/rte_stack_std.h: > > In function '__rte_stack_std_pop': > > lib/librte_stack/rte_stack_std.h:68:6: error: > > implicit declaration of function 'unlikely' > > Missing rte_branch_prediction.h include -- I'll fix and resubmit. Thanks for > checking the non-x86 builds. > > I can hold off resubmission until the 128-bit CAS patch is merged, so this > series is properly tested in the automated build + test pipeline, if you'd > prefer.
Yes, would be the best. But we need to merge everything tomorrow at last.
