On 4/2/2019 8:55 PM, David Marchand wrote: > On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: > >> On 4/2/2019 8:46 PM, David Marchand wrote: >>> On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon <tho...@monjalon.net> >> wrote: >>> >>>> Only one header file (rte_kni_common.h) was in the sub-directory >>>> include/exec-env/ >>>> This file was installed in a sub-directory of the same name >>>> in the makefile-based build. >>>> Source and install directories are moved as below: >>>> >>>> lib/librte_eal/linux/eal/include/exec-env/ >>>> -> lib/librte_eal/linux/eal/include/ >>>> >>>> build/include/exec-env/ >>>> -> build/include/ >>>> >>>> The consequence is to have a file hierarchy a bit more flat. >>>> >>>> Signed-off-by: Thomas Monjalon <tho...@monjalon.net> >>>> >>> >>> Looks good to me. >>> Reviewed-by: David Marchand <david.march...@redhat.com> >>> Tested-by: David Marchand <david.march...@redhat.com> >>> >>> >>> Bruce, while testing with meson, I noticed this: >>> kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument >>> "console". >>> WARNING: This will become a hard error in the future. >>> WARNING: Unknown keyword arguments in target rte_kni: console >> >> I am not seeing this... >> > > Ok, might be my setup: > [dmarchan@dmarchan dpdk]$ meson --version > 0.47.2 > > What should I check ?
I have '0.50.0', but no idea what to check, wait Bruce :) ?