19/03/2019 19:04, Ferruh Yigit: > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > >>> +uint16_t __rte_experimental > >> > >> Do we need _rte_experimental on function definitions? I guess only in .h > >> file, > >> function declaration is enough. > > > > Yes we need them both in .h and .c files. > > Why we need them in .c file? > I think the compiler is interested in ones in .h file, because of the > experimental checks.
We need the tag in .c file because a check is done in the ELF object by buildtools/check-experimental-syms.sh David tried a replacement of this script to run on header files, but it looks a bit slow: https://patches.dpdk.org/patch/49118/