On 10/20/2017 5:34 PM, radu.nicolau at intel.com (Nicolau, Radu) wrote: > Hi, > > I think this should be a separate patch, not bundled with a series of fixes. > The guide has to be updated as well. > And probably it's best to make the MAC configuration optional, keep a default > hardcoded table.
The comment is outstanding since 2017, meanwhile 'ipsec-secgw' changed in between. I am marking the patch as rejected, if it is still relevant please send a new version on top of latest repo. Sorry for any inconvenience caused. For reference patch: https://patches.dpdk.org/patch/30613/ > > Regards, > Radu > >> -----Original Message----- >> From: aviadye at dev.mellanox.co.il [mailto:aviadye at dev.mellanox.co.il] >> Sent: Thursday, October 19, 2017 7:53 PM >> To: dev at dpdk.org; Gonzalez Monroy, Sergio >> <sergio.gonzalez.monroy at intel.com>; De Lara Guarch, Pablo >> <pablo.de.lara.guarch at intel.com>; aviadye at mellanox.com >> Cc: borisp at mellanox.com; akhil.goyal at nxp.com; >> hemant.agrawal at nxp.com; Nicolau, Radu <radu.nicolau at intel.com>; >> Doherty, Declan <declan.doherty at intel.com>; aviadye at dev.mellanox.co.il; >> liranl at mellanox.com; nelio.laranjeiro at 6wind.com; thomas at monjalon.net >> Subject: [dpdk-dev][PATCH v2 6/6] examples/ipsec-secgw: config ethernet >> MACs dynamically >> >> From: Aviad Yehezkel <aviadye at mellanox.com> >> >> Issue: None >> Signed-off-by: Aviad Yehezkel <aviadye at mellanox.com> >> -- >> v2: > <snip> > >
