11/03/2019 17:31, Bruce Richardson:
> On Mon, Mar 11, 2019 at 03:18:11PM +0000, Andrius Sirvys wrote:
> > When compiling the ACL library on a system without AVX2 support,
> > the flags used to compile the AVX2-specific code for later run-time
> > use were not based on the regular cflags for the rest of the library.
> > This can cause errors due to symbols being missed/undefined
> > due to incorrect flags. For example,
> > when testing compilation on Alpine linux, we got:
> > error: unknown type name 'cpu_set_t'
> > due to _GNU_SOURCE not being defined in the cflags.
> >
> > This issue can be fixed by appending "-mavx2" to
> > the cflags rather than replacing them with it.
> >
> > Fixes: 5b9656b157d3 ("lib: build with meson")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Andrius Sirvys <andrius.sir...@intel.com>
> > ---
> > --- a/lib/librte_acl/meson.build
> > +++ b/lib/librte_acl/meson.build
> > - c_args: '-mavx2')
> > + c_args: cflags + ['-mavx2'])
>
> Looks to be 2 spaces rather than 1 before the opening "[", but not a big
> deal and can be fixed on apply if necessary.
>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Applied (without double space), thanks
