sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 473d1bebce ("hash: allow to store data in hash table")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima <pallantlax.poorn...@intel.com>
Acked-by: Yipeng Wang <yipeng1.w...@intel.com>
---
v3: Rebased.
v2: Addressed review comment to correct the format specifier of
hastest_key_lens.
---
app/test/test_hash_perf.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c
index 525211180..5648fce02 100644
--- a/app/test/test_hash_perf.c
+++ b/app/test/test_hash_perf.c
@@ -85,9 +85,11 @@ create_table(unsigned int with_data, unsigned int
table_index,
if (with_data)
/* Table will store 8-byte data */
- sprintf(name, "test_hash%d_data",
hashtest_key_lens[table_index]);
+ snprintf(name, sizeof(name), "test_hash%u_data",
+ hashtest_key_lens[table_index]);
else
- sprintf(name, "test_hash%d", hashtest_key_lens[table_index]);
+ snprintf(name, sizeof(name), "test_hash%u",
+ hashtest_key_lens[table_index]);
if (with_locks)
--
2.17.2
