On 3/22/19 9:46 AM, Maxime Coquelin wrote:


On 3/21/19 7:26 AM, Wenzhuo Lu wrote:
The TX setting functions is not called.

s/functions/function/


Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: sta...@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com>
---
  drivers/net/ice/ice_ethdev.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index a23c63a..b804be1 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
      }
      ice_set_rx_function(dev);
+    ice_set_tx_function(dev);
      mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
              ETH_VLAN_EXTEND_MASK;


Other than that:

Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>

Sorry, just notice I didn't fetch my mailbox, so I didn't see the v5.
Anyway my comments seem to apply to v5 too.

Maxime

Reply via email to