On Thu, Mar 21, 2019 at 03:17:22PM +0100, Maxime Coquelin wrote: > On 3/21/19 3:02 PM, Jens Freimann wrote: > > On Thu, Mar 21, 2019 at 02:45:20PM +0100, Maxime Coquelin wrote: > > > Most of 'virtqueue' struct fields are prefixed with 'vq_'. > > > This redundant, this patch removes them all. > > > > > > Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com> > > > --- > > > Hi, > > > > > > Following our discussions on removing the 'vq_' prefix, I did > > > the patch to see how it would look like.
Thanks for the work! > > > > > > It looks like it does not prevent any lines to be split but one. > > > But the code is more readable IMHO. > > > > > > I send this as RFC to get your feedback. > > > > Yes, I think it's more readable. One thing I had not thought about is > > that it makes it harder to find meaningful results from git blame > > output. Can we live with that? > > That's a valid point, and I think it might be more problematic than the > conflicts for backporting, which would be trivial to solve. > > I don't have a strong opinion on whether we should do it or not. I also don't have a strong opinion. Thanks, Tiwei > > Thanks, > Maxime > > > > regards, > > Jens
