On 3/21/2019 12:50 PM, Ian Stokes wrote: > On 3/19/2019 4:15 PM, Ferruh Yigit wrote: >> On 2/27/2019 9:45 PM, Ian Stokes wrote: >>> From: Stephen Hemminger <step...@networkplumber.org> >>> >>> This addresses the usability issue raised by OVS at DPDK Userspace >>> summit. It adds general min/max mtu into device info. For compatiablity, >>> and to save space, it fits in a hole in existing structure. >>> >>> The initial version sets max mtu to normal Ethernet, it is up to >>> PMD to set larger value if it supports Jumbo frames. >>> >>> Also remove the deprecation notice introduced in 18.11 regarding this >>> change and bump ethdev ABI version. >>> >>> Signed-off-by: Stephen Hemminger <step...@networkplumber.org> >>> Signed-off-by: Ian Stokes <ian.sto...@intel.com> >>> Acked-by: Andrew Rybchenko <arybche...@solarflare.com> >> >>> @@ -2524,6 +2524,8 @@ rte_eth_dev_info_get(uint16_t port_id, struct >>> rte_eth_dev_info *dev_info) >>> dev_info->rx_desc_lim = lim; >>> dev_info->tx_desc_lim = lim; >>> dev_info->device = dev->device; >>> + dev_info->min_mtu = ETHER_MIN_MTU; >>> + dev_info->max_mtu = UINT16_MAX; >> >> Not only mtu but do you think should we document in 'rte_eth_dev_info_get()' >> doxygen documentation, the default values that API sets? >> > > Sure, that would be useful, I can include it in the v2 of this patch. > What would you document the values under? They are not @params and not > @return, is there a particular label/format that should be used for > values set within a function?
In the description paragraph of the function perhaps? I am not aware of a label for this.
