On 3/14/2019 3:13 PM, David Marchand wrote: > Introduce a new api to retrieve per queue statistics from the drivers. > The api objectives: > - easily add some common per queue statistics and have it exposed > through the user xstats api while the user stats api is left untouched > - remove the limitations on the per queue statistics count (inherited > from ixgbe) and avoid recurrent bugs on stats array overflow
The patch is adding two new dev_ops 'rxq_stats_get' & 'txq_stats_get', my concern is if it is overkill to have three dev_ops to get stats and I am feeling that is making xstat code more complex. Would it be simpler to add 'q_ierrors' & 'q_oerrors' to 'struct rte_eth_stats'? And perhaps we can do the 'fix rxq q_errors' patchset [1] after this change, so fix can be done with less changes, although it will push the fix into next release because of the ABI break. OR ethdev will be broken this release, because of max_mtu, since ABI is already broken perhaps we can squeeze this in. Overall I would like to get more comment on this, Andrew, Thomas? > > Signed-off-by: David Marchand <david.march...@redhat.com> <...>
