Hi Fan,
title should be ipsec: support aes-ctr
On 2/19/2019 9:02 PM, Fan Zhang wrote:
> This patch adds AES-CTR cipher algorithm support to ipsec
> library.
>
> Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com>
> ---
> lib/librte_ipsec/crypto.h | 17 ++++++
> lib/librte_ipsec/sa.c | 133
> ++++++++++++++++++++++++++++++++++++++--------
> lib/librte_ipsec/sa.h | 18 +++++++
> 3 files changed, 147 insertions(+), 21 deletions(-)
>
> diff --git a/lib/librte_ipsec/crypto.h b/lib/librte_ipsec/crypto.h
> index b5f264831..4f551e39c 100644
> --- a/lib/librte_ipsec/crypto.h
> +++ b/lib/librte_ipsec/crypto.h
> @@ -11,6 +11,16 @@
> * by ipsec library.
> */
>
> +/*
> + * AES-CTR counter block format.
> + */
> +
> +struct aesctr_cnt_blk {
> + uint32_t nonce;
> + uint64_t iv;
> + uint32_t cnt;
> +} __attribute__((packed));
> +
I believe cnt should be above iv.
> /*
> * AES-GCM devices have some specific requirements for IV and AAD formats.
> * Ideally that to be done by the driver itself.
> @@ -41,6 +51,13 @@ struct gcm_esph_iv {
> uint64_t iv;
> } __attribute__((packed));
>
>
Apart from that,
Acked-by: Akhil Goyal <akhil.go...@nxp.com>
