Monday, March 11, 2019 9:58 PM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix packet inline on Tx queue wraparound
>
>
> > On Mar 10, 2019, at 12:14 AM, Shahaf Shuler <shah...@mellanox.com>
> wrote:
> >
> > Inlining a packet to WQE that cross the WQ wraparound, i.e. the WQE
> > starts on the end of the ring and ends on the beginning, is not
> > supported and blocked by the data path logic.
> >
> > However, in case of TSO, an extra inline header is required before
> > inlining. This inline header is not taken into account when checking
> > if there is enough room left for the required inline size.
> > On some corner cases were
> > (ring_tailroom - inline header) < inline size < ring_tailroom , this
> > can lead to WQE being written outsize of the ring buffer.
> >
> > Fixing it by always assuming the worse case that inline of packet will
> > require the inline header.
> >
> > Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Shahaf Shuler <shah...@mellanox.com>
> > ---
>
> Acked-by: Yongseok Koh <ys...@mellanox.com>
Applied to next-net-mlx, thanks.
