Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, February 28, 2019 10:59 AM > To: Shally Verma <shal...@marvell.com>; Kusztal, ArkadiuszX > <arkadiuszx.kusz...@intel.com>; dev@dpdk.org > Cc: Trahe, Fiona <fiona.tr...@intel.com>; > shally.ve...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod > exp and inverse operations > > > > On 2/12/2019 4:25 PM, Shally Verma wrote: > > > >> -----Original Message----- > >> From: Arek Kusztal <arkadiuszx.kusz...@intel.com> > >> Sent: 08 February 2019 16:44 > >> To: dev@dpdk.org > >> Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; > >> shally.ve...@caviumnetworks.com; Arek Kusztal > >> <arkadiuszx.kusz...@intel.com> > >> Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and > >> inverse operations > >> > >> External Email > >> > >> This commit adds result field to be used when modular exponentiation > >> or modular multiplicative inverse operation is used > >> > >> Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> > >> --- > > Acked-by: Shally Verma <shal...@marvell.com> > > > >> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > >> b/lib/librte_cryptodev/rte_crypto_asym.h > >> index 0a50cd5..991263f 100644 > >> --- a/lib/librte_cryptodev/rte_crypto_asym.h > >> +++ b/lib/librte_cryptodev/rte_crypto_asym.h > >> @@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param { > >> * be relatively prime to modulus in corresponding Modular > >> * Multiplicative Inverse rte_crypto_modinv_xform > >> */ > >> + > >> + rte_crypto_param result; > ABI breakage?? > Do we have a deprecation notice? Is not asymmetric crypto API still experimental? Do we have then add deprecation notice?
> >> + /**< > >> + * Pointer to the result of modular exponentiation/multiplicative > inverse > >> + * data in octet-string network byte order format. > >> + * > >> + * This field shall be big enough to hold the result of Modular > >> + * Exponentiation or Modular Multplicative Inverse > >> + * (bigger or equal to length of modulus) > >> + */ > >> }; > >> > >> /** > >> -- > >> 2.1.0 Thanks, Arek
