> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Gajdzica, MaciejX T > Sent: Wednesday, August 12, 2015 2:58 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the > list > > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Wednesday, August 12, 2015 2:53 PM > > To: Gajdzica, MaciejX T > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test > > to the list > > > > 2015-08-12 14:41, Maciej Gajdzica: > > > test_table_ACL wasn't invoked when running table_autotest. Added > > > this test to table_tests array to make it run with other table tests. > > > > > > Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica at intel.com> > > [...] > > > --- a/app/test/test_table_tables.h > > > +++ b/app/test/test_table_tables.h > > > @@ -36,7 +36,7 @@ int test_table_lpm(void); int > > > test_table_lpm_ipv6(void); int test_table_array(void); #ifdef > > > RTE_LIBRTE_ACL -int test_table_acl(void); > > > +int test_table_ACL(void); > > > > Why renaming it uppercase? > > Function names should be lowercase. > > > > It is lowercase also in app/test/test_table_combined.h > > Yes, but in app/test/test_table_acl.c it is uppercase, and there is no > definition > for lowercase function. I can change name in test_table_acl.c to lowercase.
In current code ACL table tests are executed at the end after table tests and table tests combined, so this patch is not needed. I will only send patch with function name renamed to lowercase. Best Regards Maciek
