On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chaitanya Babu Talluri >> Sent: Friday, January 18, 2019 8:54 PM >> To: dev@dpdk.org >> Cc: rm...@marvell.com; Pattan, Reshma <reshma.pat...@intel.com>; >> shsha...@marvell.com; Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z >> <qi.z.zh...@intel.com>; alejandro.luc...@netronome.com; De Lara Guarch, >> Pablo <pablo.de.lara.gua...@intel.com>; Doherty, Declan >> <declan.dohe...@intel.com>; Chaitanya Babu, TalluriX >> <tallurix.chaitanya.b...@intel.com>; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat >> >> Strcat does not check the destination length and there might be chances of >> string overflow so insted of strcat, strncat is used. >> >> Fixes: 540a211084 ("bnx2x: driver core") >> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") >> Fixes: ef28aa96e5 ("net/nfp: support multiprocess") >> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.b...@intel.com>
<...> > > Any Review Please!! > cc'ed Bruce & Thomas. What do you think getting strlcat() patch first and updating this patch to use strlcat()? Are we OK to get strlcat as the default API? Thanks, ferruh