There is only one ack for this change. A deprecation requires more agreement (3 valuable acks). Other opinions?
31/01/2019 10:53, Akhil Goyal: > On 1/17/2019 3:09 PM, Anoob Joseph wrote: > > Add new field ff_enable in rte_cryptodev_config. This enables > > applications to control the features enabled on the crypto device. > > > > Proposed new layout: > > > > /** Crypto device configuration structure */ > > struct rte_cryptodev_config { > > int socket_id; /**< Socket to allocate resources on */ > > uint16_t nb_queue_pairs; > > /**< Number of queue pairs to configure on device */ > > + uint64_t ff_enable; > > + /**< Feature flags to be enabled on the device. Only the features set > > + * on rte_cryptodev_info.feature_flags are allowed to be set. > > + */ > > }; > > > > For eth devices, rte_eth_conf.rx_mode.offloads and > > rte_eth_conf.tx_mode.offloads fields are used by applications to > > control the offloads enabled on the eth device. This proposal adds a > > similar ability for the crypto device. > > > > Signed-off-by: Anoob Joseph <ano...@marvell.com> > > > Acked-by: Akhil Goyal <akhil.go...@nxp.com>