25/01/2019 15:12, Burakov, Anatoly: > On 25-Jan-19 2:00 PM, Ilya Maximets wrote: > > On 25.01.2019 16:48, Burakov, Anatoly wrote: > >> On 25-Jan-19 9:53 AM, David Marchand wrote: > >>> > >>> Reviewed-by: David Marchand <david.march...@redhat.com > >>> <mailto:david.march...@redhat.com>> > >> > >> Now that i think of it, maybe it's not that simple. > >> > >> --socket-mem/-m flag with zero is still an invalid value *if* --legacy-mem > >> is involved. However, it is a valid value in non-legacy mode. > >> > >> So maybe the test should reflect this, and the previous fix should have > >> instead added a check for legacy mode rather than disabling the zero check > >> outright. > >> > > > > I don't think that it's a big deal, because "--socket-mem=0 --legacy-mem" > > quickly fails with clear: > > > > EAL: WARNING: Master core has no memory on local socket! > > > > IMHO, It's actually more informative than previous: > > > > EAL: invalid parameters for --socket-limit > > > > I agree that we could add a test for a legacy-mem cases, but that's a bit > > different task. > > Good point. Maybe leave it as is then :) > > Acked-by: Anatoly Burakov <anatoly.bura...@intel.com>
Applied, thanks
