Hi Pablo,
2015-08-07 10:08, Pablo de Lara:
> L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts",
> instead it should be "simple_ipv6_fwd_8pkts".
>
> Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8")
There are 3 things wrong here.
1/ We must absolutely avoid compile-time paths:
#if (ENABLE_MULTI_BUFFER_OPTIMIZE == 1)
#if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)
It makes test coverage too hard to track.
2/ When replacing a function, grepping it is a must have.
-simple_ipv6_fwd_4pkts(struct rte_mbuf* m[4], uint8_t portid, struct lcore_conf
*qconf)
+simple_ipv6_fwd_8pkts(struct rte_mbuf *m[8], uint8_t portid, struct lcore_conf
*qconf)
So this change would be straight forward:
> -
> simple_ipv6_fwd_4pkts(&pkts_burst[j],
> +
> simple_ipv6_fwd_8pkts(&pkts_burst[j],
3/ The above commit makes also this wrong replacement:
-
simple_ipv4_fwd_4pkts(&pkts_burst[j],
+
simple_ipv8_fwd_4pkts(&pkts_burst[j],
It is still not fixed.
Please send a v2 for this last typo. Thanks
