On Tue, 2019-01-22 at 13:46 +0000, Bruce Richardson wrote: > On Tue, Jan 22, 2019 at 01:10:52PM +0000, Luca Boccassi wrote: > > Whenever possible (if the library ships a pkg-config file) use > > meson's > > dependency() function to look for it, as it will automatically add > > it > > to the Requires.private list if needed, to allow for static builds > > to > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > dependencies are not parsed, and users doing static builds have to > > resolve them manually by themselves. > > When using this API avoid additional checks that are superfluous > > and > > take extra time, and avoid adding the linker flag manually which > > causes > > it to be duplicated. > > > > Signed-off-by: Luca Boccassi <bl...@debian.org> > > --- > > v2: split libbsd change in a separate commit, remove CC to stable > > as a meson bump will be required > > v4: update comment in drivers/meson.build to clarify role of > > pkgconfig_extra_libs > > v5: remove -lz from drivers/compress/zlib > > How is this removal possible? Does drivers/compress/zlib no longer > depend > on libz, or is there a dependency added somewhere else in this patch > that > I'm missing? Similar question with the -lcrypto removal? > > /Bruce
Note that the removal is from the pkgconfig_extra_libs list - same for lcrypto. They use dependency() already, and the dep is added to the ext_deps, so the dependency comes in that way (and the right flags are picked via pkg-config). -- Kind regards, Luca Boccassi
