Hi Andrew,

Would you please give more explanation about the problem that
the patch wants to fix?

Thanks,
Jiayu
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybche...@solarflare.com]
> Sent: Friday, January 18, 2019 9:29 PM
> To: Hu, Jiayu <jiayu...@intel.com>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] gso: fix VxLAN/GRE tunnel checks
> 
> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
> 
> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
> Fixes: 70e737e448c7 ("gso: support GRE GSO")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
> ---
>  lib/librte_gso/gso_common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
> index 6cd764ff5..b6ff1b886 100644
> --- a/lib/librte_gso/gso_common.h
> +++ b/lib/librte_gso/gso_common.h
> @@ -22,12 +22,12 @@
>               (PKT_TX_TCP_SEG | PKT_TX_IPV4))
> 
>  #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> -                             PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_VXLAN)) == \
> +                             PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
>               (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
>                PKT_TX_TUNNEL_VXLAN))
> 
>  #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
> PKT_TX_IPV4 | \
> -                             PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_GRE)) == \
> +                             PKT_TX_OUTER_IPV4 |
> PKT_TX_TUNNEL_MASK)) == \
>               (PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
> \
>                PKT_TX_TUNNEL_GRE))
> 
> --
> 2.17.1

Reply via email to