From: David Marchand [mailto:david.march...@redhat.com] Sent: Wednesday, January 16, 2019 4:29 PM To: Zhao1, Wei <wei.zh...@intel.com> Cc: dev@dpdk.org; dpdk stable <sta...@dpdk.org>; Lu, Wenzhuo <wenzhuo...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com> Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF
On Wed, Jan 16, 2019 at 6:08 AM Wei Zhao <wei.zh...@intel.com<mailto:wei.zh...@intel.com>> wrote: There is need to enable promiscuous mode enable on VF, pf host should also enable to support that. Zhao Wei (3): net/ixgbe: promiscuous mode enable on VF net/ixgbe: enable promiscous mode on PF host net/ixgbe: update API version drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++ drivers/net/ixgbe/ixgbe_ethdev.h | 1 + drivers/net/ixgbe/ixgbe_pf.c | 79 +++++++++++++++++++++++++++++----------- 3 files changed, 79 insertions(+), 22 deletions(-) -- 2.7.5 This series looks more about a missing feature than a proper fix. We have a new pf/vf api supported in this series and a new behaviour for promiscuous. This is not stable material to me unless you expose a clear problem that this series wants to address. Yes, this a new feature enable related, but this patch set will not introduce problem, because vf promiscuous mode is close by default, this set is just send out for request from users that want to use vf promiscuous. They will open it in their APP. NOT only ixgbe, but also other NIC vf HAS SUPPORT this feature. -- David Marchand
