Hi > -----Original Message----- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, January 15, 2019 10:37 PM > To: Pattan, Reshma <reshma.pat...@intel.com> > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Rao, Nikhil > <nikhil....@intel.com>; olivier.m...@6wind.com; tho...@monjalon.net; > Singh, Jasvinder <jasvinder.si...@intel.com>; Dumitrescu, Cristian > <cristian.dumitre...@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for > sched field > > On Thu, 20 Dec 2018 12:16:09 +0000 > Reshma Pattan <reshma.pat...@intel.com> wrote: > > > This patch implements the changes proposed in the deprecation notes > > [1][2]. > > > > librte_mbuf changes: > > The mbuf->hash.sched field is updated to support generic definition in > > line with the ethdev traffic manager and meter APIs. > > The new generic format contains: queue ID, traffic class, color. > > > > Added public APIs to set and get these new fields to and from mbuf. > > > > librte_sched changes: > > In addtion, following API functions of the sched library have been > > modified with an additional parameter of type struct rte_sched_port to > > accommodate the changes made to mbuf sched field. > > (i)rte_sched_port_pkt_write() > > (ii) rte_sched_port_pkt_read_tree_path() > > > > librte_pipeline, qos_sched UT, qos_sched app are updated to make use > > of new changes. > > > > Also mbuf->hash.txadapter has been added for eventdev txq, > > rte_event_eth_tx_adapter_txq_set and > > rte_event_eth_tx_adapter_txq_get() > > are updated to use mbuf->hash.txadapter.txq. > > > > doc: > > Release notes updated. > > Removed deprecation notice for mbuf->hash.sched and sched API. > > > > [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html > > [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html > > > > Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com> > > Signed-off-by: Reshma Pattan <reshma.pat...@intel.com> > > Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com> > > Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > > This patch breaks build of VPP because it refers to sched.hi and sched.lo. > Breaking source compatibility is as bad (if not worse) than ABI breakage. >
Yes this breaks the build and we have actions to fix VPP Qos Sched when DPDK 19.02 is formally integrated to VPP. Thanks, Reshma
