On Mon, Jan 14, 2019 at 6:54 PM Thomas Monjalon <tho...@monjalon.net> wrote:
> 14/01/2019 19:29, Alejandro Lucero: > > On Mon, Jan 14, 2019 at 6:22 PM Ferruh Yigit <ferruh.yi...@intel.com> > wrote: > > > > > On 1/14/2019 6:00 PM, Alejandro Lucero wrote: > > > > > > > > > > > > On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit < > ferruh.yi...@intel.com > > > > <mailto:ferruh.yi...@intel.com>> wrote: > > > > > > > > On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > > > > > 11/01/2019 17:42, Ferruh Yigit: > > > > >> On 1/11/2019 1:25 PM, Alejandro Lucero wrote: > > > > >>> The Netronome's Network Flow Processor chip is highly > > > programmable > > > > >>> with the goal of processing packets at high speed. Processing > > > units > > > > >>> and other chip components are available from the host > through the > > > > >>> PCIe CPP(Command Push Pull bus) interface. The NFP PF PMD > > > configures > > > > >>> a CPP handler for setting up and working with vNICs, perform > > > actions > > > > >>> like link up or down, or accessing extended stats from the > MAC > > > component. > > > > >>> > > > > >>> There exist NFP host tools which access the NFP components > for > > > > >>> programming and debugging but they require the CPP interface. > > > When the > > > > >>> PMD is bound to the PF, the DPDK app owns the CPP interface, > so > > > these > > > > >>> host tools can not access the NFP through other means like > NFP > > > kernel > > > > >>> drivers. > > > > >>> > > > > >>> This patch adds a CPP bridge using the rte_service API which > can > > > be > > > > >>> enabled by a DPDK app. Interestingly, DPDK clients like OVS > will > > > not > > > > >>> enable specific service cores, but this can be performed > with a > > > > >>> secondary process specifically enabling this CPP bridge > service > > > and > > > > >>> therefore giving access to the NFP to those host tools. > > > > >>> > > > > >>> v2: > > > > >>> - Avoid printfs for debugging > > > > >>> - fix compilation problems for powerpc > > > > >>> > > > > >>> Signed-off-by: Alejandro Lucero < > alejandro.luc...@netronome.com > > > > <mailto:alejandro.luc...@netronome.com>> > > > > >> > > > > >> Applied to dpdk-next-net/master, thanks. > > > > > > > > > > It does not compile with 32-bit toolchain. > > > > > > > > > > Please check the occurences of %lu, thanks. > > > > > > > > Hi Thomas, > > > > > > > > We aware the build error, but let it because nfp doesn't support > > > 32-bit. > > > > > > > > But I just recognized that it is enabled by default on 32-bit > > > default configs, > > > > we should disable them. > > > > > > > > > > > > Hi Alejandro, > > > > > > > > Can you please disable nfp driver explicitly on > > > > 'defconfig_i686-native-linuxapp-*' config files, perhaps also on > > > > 'defconfig_x86_x32-native-linuxapp-gcc' too? > > > > > > > > I will drop the existing patch from next-net. > > > > > > > > > > > > Ok. I'll do asap. > > > > > > > > > > > > And if it is possible to fix the build error, specially if it is > > > just for %lu of > > > > the logging, I prefer the fix against the config update, but it > is > > > up to you. > > > > > > > > > > > > I did not see any logging error/warning when compiling nor any when > using > > > > checkpatch. I have used a gcc 7.3.1 (Ubuntu) and a 8.2.1 (RH). What > are > > > you > > > > using for triggering such error? > > > > > > Using 'i686-native-linuxapp-gcc' config, which is for 32-bit, gives > > > following > > > build error [1] with this patch. > > > > > > > > OK. But after the patch I have just sent for removing NFP PMD from 32 > bits > > builds, nothing is really needed then. Right? > > > > If so, should I send the patch again about the CPP bridge or you can redo > > it? > > I will re-apply it on master. > > > Great. Thanks!
