10/01/2019 17:50, Harry van Haaren: > Although C compilation works with the struct rte_mbuf_sched > declared inside the struct rte_mbuf namespace, C++ fails to > compile. This fix moves the rte_mbuf_sched struct up to the > global namespace, instead of declaring it inside the struct > mbuf namespace. > > The struct rte_mbuf_sched is being used on the stack in > rte_mbuf_sched_get() and as a cast in _set(). For this > reason, it must be exposed as an available type. > > Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field") > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > --- > > Cc: reshma.pat...@intel.com > Cc: cristian.dumitre...@intel.com > Cc: tho...@monjalon.net > > Hey folks, > > Currently the mbuf header will fail to compile with a C++ compiler, > this patch is one possible solution. I'm not particularly happy with > this as a fix as it reduces mbuf struct readability, however it does > resolve the issue.
What are the other possible solutions?