09/01/2019 21:51, Bruce Richardson:
> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote:
> > On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov
> > <[1]anatoly.bura...@intel.com> wrote:
> >
> > Currently, while EAL does depend on librte_compat as far as common
> > meson build is concerned, for some reason the headers for that
> > library are not added into the list of includes. This is fixed in
> > Linuxapp-specific meson file, but is absent from FreeBSD meson file.
> > This worked fine up until recently, when an rte_compat dependency
> > was added to rte_log, which is a common header. Fix this issue by
> > adding librte_compat includes to common EAL meson file.
> > Fixes: 844514c73569 ("eal: build with meson")
> > Fixes: a8499f65a1d1 ("log: add missing experimental tag")
> > Cc: [2]bruce.richard...@intel.com
> > Cc: [3]david.march...@redhat.com
> > Cc: [4]sta...@dpdk.org
> > Signed-off-by: Anatoly Burakov <[5]anatoly.bura...@intel.com>
> >
> > lgtm, thanks.
> > Reviewed-by: David Marchand <[6]david.march...@redhat.com>
> > --
> > David Marchand
> >
> Agreed.
> One other point I'd make is that having compat as a separate library seems
> a little like overkill to me - it's just one header file! Is there a reason
> why we don't just move it into the EAL where everyone can use it without
> having to specify another dependency?
+1 for moving compat into EAL.
