On 1/9/2019 3:24 PM, Ilya Maximets wrote: > On 09.01.2019 17:55, Michael S. Tsirkin wrote: >> On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >>> Version 3: >>> * Added 2 patches with fixes for current virtio driver. >>> Not directly connected with the new feature. >> >> New version shouldn't be reply-to old one really :). > > It's kind of a common practice and a recommended thing for the > dpdk mail-list. At least it was. > I'm not doing that on other lists. =)
Yes this is something recommended to do. It helps a lot to be able to see all versions and comments in same email thread. > >> But the patches are good I think. >> >> Acked-by: Michael S. Tsirkin <m...@redhat.com> > > Thanks. > >> >> >> >>> Version 2: >>> * rebased on current master (packed rings). >>> >>> RFC --> Version 1: >>> * Dropped vendor-specific hack to determine if we need real barriers. >>> * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. >>> >>> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER >>> to VIRTIO_F_ORDER_PLATFORM is not merged yet: >>> >>> https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html >>> >>> Ilya Maximets (3): >>> net/virtio: add missing barrier before reading the flags >>> net/virtio: update memory ordering comment for vq notify >>> net/virtio: add platform memory ordering feature support >>> >>> drivers/net/virtio/virtio_ethdev.c | 2 ++ >>> drivers/net/virtio/virtio_ethdev.h | 3 +- >>> drivers/net/virtio/virtio_pci.h | 7 ++++ >>> drivers/net/virtio/virtio_rxtx.c | 16 ++++----- >>> drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- >>> 5 files changed, 63 insertions(+), 21 deletions(-) >>> >>> -- >>> 2.17.1 >> >>
