On 12/25/2018 7:29 PM, Rami Rosen wrote: > Hi Saleh, > Thanks for your patch. > If you will grep into the DPDK repo you will see that there are several > occurrences of IP_VHL_DEF, with the same functionality. > I would consider putting the IPV4_VHL_DEF you added in a more generic > location and not > under testpmd, so other modules will be able to use it without the need to > include testpmd.h, which is a bit awkard. > Another question is whether it should be IPV4_VHL_DEF or IPV_VHL_DEF as in > other DPDK apps. Probably other apps should be adjusted to use it.
+1. Why not put IPV4_VERSION (IPV6_VERSION), IPV4_DEFAULT_HDRLEN & IPV4_VHL_DEF to 'librte_net/rte_ip.h' and update libs/apps to use them? cc'ed Olivier. And instead of defining ourselves, which we are trying to get rid of, is there any system ones that we can re-use? > > Regards, > Rami Rosen >
