2015-08-02 22:04, Matthew Hall: > On Mon, Aug 03, 2015 at 09:46:54AM +0800, Liang, Cunming wrote: > > According to the API definition, if the socket could not be determined, a > > default of zero will take. > > The '-1' is returned when the port_id value is out of range. > > Yes, but when I asked the exact same question and was told the documentation > was wrong not the -1 return value.
It was an error. The correct API, as defined, is to return 0 when there is no NUMA. This patch now reverts this one: http://dpdk.org/browse/dpdk/commit/?id=a4ff75496a18 Thanks Matthew for helping to clarify it. > Sure, if nobody objects like the last time I asked. But this will change the > user behavior as I am looking for the -1 now. You're right. But this fix follows the defined API, so it's rather an API fix than an API break. Applied, thanks