Hi,
On Wed, Dec 19, 2018 at 09:32:09AM +0000, Akhil Goyal wrote:
>
>
> On 12/14/2018 9:53 PM, Konstantin Ananyev wrote:
> > Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com>
> > Acked-by: Mohammad Abdul Awal <mohammad.abdul.a...@intel.com>
> > Acked-by: Declan Doherty <declan.dohe...@intel.com>
> > ---
> > lib/librte_net/rte_esp.h | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h
> > index f77ec2eb2..8e1b3d2dd 100644
> > --- a/lib/librte_net/rte_esp.h
> > +++ b/lib/librte_net/rte_esp.h
> > @@ -11,7 +11,7 @@
> > * ESP-related defines
> > */
> >
> > -#include <stdint.h>
> > +#include <rte_byteorder.h>
> >
> > #ifdef __cplusplus
> > extern "C" {
> > @@ -25,6 +25,14 @@ struct esp_hdr {
> > rte_be32_t seq; /**< packet sequence number */
> > } __attribute__((__packed__));
> >
> > +/**
> > + * ESP Trailer
> > + */
> > +struct esp_tail {
> > + uint8_t pad_len; /**< number of pad bytes (0-255) */
> > + uint8_t next_proto; /**< IPv4 or IPv6 or next layer header */
> > +} __attribute__((__packed__));
> > +
> > #ifdef __cplusplus
> > }
> > #endif
> Acked-by: Akhil Goyal <akhil.go...@nxp.com>
Is there a reason to pack the structure? I think it has no impact since
it is only composed of uint8_t, so it can be removed.
Thanks,
Olivier
