On Wed, Dec 19, 2018 at 01:37:18PM +0900, Hideyuki Yamashita wrote:
> The common data freeing has been moved to rte_eth_dev_release_port(),
> so freeing mac_addrs like this in eth_dev_close() is unnecessary and
> will cause double free.
>
> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Hideyuki Yamashita <yamashita.hidey...@po.ntt-tx.co.jp>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasuf...@lab.ntt.co.jp>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c
> b/drivers/net/vhost/rte_eth_vhost.c
> index 42bdfcbd5..b2cda0483 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1000,7 +1000,6 @@ eth_dev_close(struct rte_eth_dev *dev)
> for (i = 0; i < dev->data->nb_tx_queues; i++)
> rte_free(dev->data->tx_queues[i]);
>
> - rte_free(dev->data->mac_addrs);
> free(internal->dev_name);
> free(internal->iface_name);
> rte_free(internal);
> --
> 2.18.0
Reviewed-by: Tiwei Bie <tiwei....@intel.com>
