19/12/2018 08:41, Qi Zhang: > When secondary process quit, the mp_socket* file still exist, that > cause rte_mp_request_sync fail when try to send message on a floating > socket. > > The patch fix the issue by introduce a function rte_mp_channel_fini. > This function will be called by rte_eal_cleanup and it will close the > mp socket and delete the mp_socket* file.
Why not call it rte_mp_channel_cleanup, keeping the same wording? [...] > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -1229,6 +1229,7 @@ rte_eal_cleanup(void) > if (rte_eal_process_type() == RTE_PROC_PRIMARY) > rte_memseg_walk(mark_freeable, NULL); > rte_service_finalize(); > + rte_mp_channel_fini(); > return 0; > } Should be called in bsdapp/eal?
