Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, December 18, 2018 7:47 AM > To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org > Cc: Yang, Qiming <qiming.y...@intel.com>; Li, Xiaoyun > <xiaoyun...@intel.com>; Wu, Jingjing <jingjing...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v5 30/31] net/ice: support advance RX/TX > > On 12/17/2018 7:37 AM, Wenzhuo Lu wrote: > > Add RX functions, scatter and bulk. > > Add TX function, simple. > > > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > > Signed-off-by: Qiming Yang <qiming.y...@intel.com> > > Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com> > > Signed-off-by: Jingjing Wu <jingjing...@intel.com> > > <....> > > > + rxdp = &rxq->rx_ring[alloc_idx]; > > + for (i = 0; i < rxq->rx_free_thresh; i++) { > > + if (likely(i < (rxq->rx_free_thresh - 1))) > > + /* Prefetch next mbuf */ > > + rte_prefetch0(rxep[i + 1].mbuf); > > + > > + mb = rxep[i].mbuf; > > + rte_mbuf_refcnt_set(mb, 1); > > + mb->next = NULL; > > + mb->data_off = RTE_PKTMBUF_HEADROOM; > > + mb->nb_segs = 1; > > + mb->port = rxq->port_id; > > + dma_addr = > rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb)); > > + rxdp[i].read.hdr_addr = 0; > > + rxdp[i].read.pkt_addr = dma_addr; > > + } > > + > > + /* Update rx tail regsiter */ > > Can you please double check checkpatch warnings, some of them can be > ignored but some are easy to fix issues: > WARNING:TYPO_SPELLING: 'regsiter' may be misspelled - perhaps 'register'? My bad. I remember I did handle this. But looks like this work lost by mistake. Will check it again.
> #201: FILE: drivers/net/ice/ice_lan_rxtx.c:1112: > + /* Update rx tail regsiter */