> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Friday, December 14, 2018 11:36 PM
> To: Pattan, Reshma <reshma.pat...@intel.com>; dev@dpdk.org;
> Dumitrescu, Cristian <cristian.dumitre...@intel.com>;
> jerin.ja...@caviumnetworks.com; Singh, Jasvinder
> <jasvinder.si...@intel.com>
> Cc: Pattan, Reshma <reshma.pat...@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition
>
> Hi Reshma,
>
> > diff --git a/lib/librte_eal/common/include/rte_color.h
> b/lib/librte_eal/common/include/rte_color.h
> > new file mode 100644
> > index 000000000..f4387071b
> > --- /dev/null
> > +++ b/lib/librte_eal/common/include/rte_color.h
> > @@ -0,0 +1,18 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2018 Intel Corporation
> > + */
> > +
> > +#ifndef _RTE_COLOR_H_
> > +#define _RTE_COLOR_H_
> > +
> > +/**
> > + * Color
> > + */
> > +enum rte_color {
> > + RTE_COLOR_GREEN = 0, /**< Green */
> > + RTE_COLOR_YELLOW, /**< Yellow */
> > + RTE_COLOR_RED, /**< Red */
> > + RTE_COLORS /**< Number of colors */
> > +};
>
> Does it really belong to EAL?
> Konstantin
>
Why not?
It needs to be visible to multiple libraries: ethdev, meter, sched, as well as
drivers. We'd like to avoid adding more complexity to dependencies between
libraries.
It is very generic. EAL common/include is currently the place to put generic
data structures, functions, algs, etc that are widely used by DPDK libraries.
Lots of similar examples are easy to find in this folder.
Where else would you put it?
> > +
> > +#endif /* _RTE_COLOR_H_ */
