On Thu, Dec 13, 2018 at 10:07:09AM -0800, Stephen Hemminger wrote: > On Thu, 13 Dec 2018 14:30:51 +0100 > Jakub Grajciar <jgraj...@cisco.com> wrote: > > > + > > +typedef uint16_t memif_region_index_t; > > +typedef uint32_t memif_region_offset_t; > > +typedef uint64_t memif_region_size_t; > > +typedef uint16_t memif_ring_index_t; > > +typedef uint32_t memif_interface_id_t; > > +typedef uint16_t memif_version_t; > > +typedef uint8_t memif_log2_ring_size_t; > > + > > Seems very typedef heavy to me. Having more typedefs > does not improve the readability. >
+1 Our coding guidelines generally recommend against using typedefs, though they generally refer to structure typedefs rather than typedefs for basic types. /Bruce
